Repository navigation
Add Mono API MaD java - #23088
Open
knewbury01 wants to merge 4 commits into
Open
Add Mono API MaD java#23088knewbury01 wants to merge 4 commits into
knewbury01 wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Critical gaps in Mono factory and mapper summaries prevent input and callback-result taint from reaching returned elements, and current tests do not cover emitted values or chained operators.
2 open issues
What changed in this PR
Adds initial models-as-data support for Reactor’s Mono API to Java CodeQL analysis, with focused taint-flow tests and API stubs.
Changes:
- Adds summaries for
just,justOrEmpty,flatMap,map, andmapNotNull. - Adds positive and negative taint-flow fixtures and test configuration.
- Adds a minimal Reactor stub and its license.
| File | Description |
|---|---|
java/ql/test/stubs/reactor-core/reactor/core/publisher/Mono.java |
Defines the Mono APIs used by the tests. |
java/ql/test/stubs/reactor-core/LICENSE.txt |
Supplies the Apache 2.0 license. |
java/ql/test/library-tests/frameworks/reactor-core/test.ql |
Configures taint sources, sinks, and inline assertions. |
java/ql/test/library-tests/frameworks/reactor-core/Test.java |
Exercises factories and mapper callback inputs. |
java/ql/test/library-tests/frameworks/reactor-core/test.expected |
Provides the expected-results artifact. |
java/ql/test/library-tests/frameworks/reactor-core/options |
Adds Reactor stubs to the test classpath. |
java/ql/lib/ext/reactor.core.publisher.model.json |
Defines Mono flow summaries for Java analysis. |
Review effort: Balanced (auto)
Comment on lines
+9
to
+10
| ["reactor.core.publisher", "Mono", true, "justOrEmpty", "", "", "Argument[0]", "Argument[this]", "taint", "manual"], | ||
| ["reactor.core.publisher", "Mono", true, "just", "", "", "Argument[0]", "Argument[this]", "taint", "manual"], |
Comment on lines
+11
to
+13
| ["reactor.core.publisher", "Mono", true, "flatMap", "", "", "Argument[this].Element", "Argument[0].Parameter[0]", "taint", "manual"], | ||
| ["reactor.core.publisher", "Mono", true, "map", "", "", "Argument[this].Element", "Argument[0].Parameter[0]", "taint", "manual"], | ||
| ["reactor.core.publisher", "Mono", true, "mapNotNull", "", "", "Argument[this].Element", "Argument[0].Parameter[0]", "taint", "manual"] |
owen-mc
reviewed
Nov 11, 2026
owen-mc
reviewed
Nov 11, 2026
owen-mc
reviewed
Nov 11, 2026
owen-mc
reviewed
Nov 11, 2026
owen-mc
reviewed
Nov 11, 2026
owen-mc
reviewed
Nov 11, 2026
owen-mc
reviewed
Nov 11, 2026
owen-mc
reviewed
Nov 11, 2026
owen-mc
reviewed
Nov 11, 2026
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com>
owen-mc
reviewed
Nov 11, 2026
Contributor
|
@knewbury01 You need to update the .expected file (I can't make suggests on the empty file through the PR interface). Once you've done that, I think this is good to merge. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.